Support of DateTime and Date formats #937
Draft
+136
−62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expobrain
changed the title
lafrech
reviewed
Sep 6, 2024
| @@ -574,16 +573,62 @@ def datetime2properties(self, field, **kwargs: typing.Any) -> dict: | |||
| "example": "1676451277514.654", | |||
| "min": "0", | |||
| } | |||
| elif field.format is not None: | |||
There was a problem hiding this comment.
At this point, field.format can't be None due to line 549, right?
|
Also, format and pattern should not ever by None, according to openapi spec they must be strings. Probably should be removed from the ret dict when they are None. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds full support for rendering Date and DateTime Marshmallow fields with each of their
formatvalues.This solve the issue of
DateandDateTimewith a non-default format being rendered withformat: nullinstead offormat: dateandformat: date-timerespectively.